Fix potential deadlock in hedging request #7962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kade.lee <tjdwls1201@gmail.com>
MichaHoffmann
approved these changes
Dec 5, 2024
3 tasks
3 tasks
3 tasks
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 11, 2024
Signed-off-by: kade.lee <tjdwls1201@gmail.com>
saswatamcode
pushed a commit
to saswatamcode/thanos
that referenced
this pull request
Dec 11, 2024
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
saswatamcode
added a commit
that referenced
this pull request
Dec 11, 2024
* Fix potential deadlock in hedging request (#7962) Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> * sidecar: fix limit mintime (#7970) Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Cut patch release v0.37.2 Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix changelog Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: SungJin1212 <tjdwls1201@gmail.com> Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Co-authored-by: SungJin1212 <tjdwls1201@gmail.com> Co-authored-by: Michael Hoffmann <mhoffm@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the potential deadlock situation when the
err = hrt.TDigest.Add(duration)line gets an error.Verification